Skip to content

User32: Added LockWorkStation, ExitWindowsEx, AdjustWindowRect[Ex], and Get/SetWindowPlacement#339

Closed
Timeroot wants to merge 3 commits intojava-native-access:masterfrom
Timeroot:master
Closed

User32: Added LockWorkStation, ExitWindowsEx, AdjustWindowRect[Ex], and Get/SetWindowPlacement#339
Timeroot wants to merge 3 commits intojava-native-access:masterfrom
Timeroot:master

Conversation

@Timeroot
Copy link
Copy Markdown
Contributor

WinUser: Added ExitWindows codes, Window Style codes, and the
WindowPlacement structure.

Get/SetWindowPlacement.
WinUser: Added ExitWindows codes, Window Style codes, and the
WindowPlacement structure.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "better" way of doing this is to use ignore. Or maybe to mark the test private (I think it doesn't run in that case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to use ignore we would need to use JUnit 4's style; instead of TestCase subclasses with testXXXX() methods, classes that are standalone and whose methods use @test annotations. Is it okay to convert this, then?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that just works (we rely on JUnit 4 right?) then totally.

@dblock
Copy link
Copy Markdown
Member

dblock commented Jun 21, 2014

This is great, see comments above. Please also update CHANGES.

@Timeroot
Copy link
Copy Markdown
Contributor Author

Should be ready to go now I think.

@dblock
Copy link
Copy Markdown
Member

dblock commented Jun 25, 2014

The command line build is broken with this, it would need to be fixed, too. Run ant from contrib/platform.

@Timeroot
Copy link
Copy Markdown
Contributor Author

Had trouble actually building on my machine -- even with the old version, I think I have something misconfigured -- but I believe the problem ought be fixed by just updating the JUnit jar from 3.8 to 4.1. Also fixed two uses of a <> generic which wouldn't build.

@dblock
Copy link
Copy Markdown
Member

dblock commented Jun 27, 2014

Merged via 6379317?w=1

@dblock dblock closed this Jun 27, 2014
mstyura pushed a commit to mstyura/jna that referenced this pull request Sep 9, 2024
…-access#339)


Motivation:

The toString() method of QuicConnectionAddress did produce a not so useful string representation.

Modifications:

Use a hexdump presentation of the id

Result:

Fixes netty/netty-incubator-codec-quic#338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants