Added SetupDiOpenDevRegKey(..), SetupDiEnumDeviceInfo(..) and some constants#335
Added SetupDiOpenDevRegKey(..), SetupDiEnumDeviceInfo(..) and some constants#335ChristianSchwarz wants to merge 4 commits intojava-native-access:masterfrom ChristianSchwarz:master
Conversation
SetupDiEnumDeviceInfo(..) and some constants associated with it.
There was a problem hiding this comment.
Should probably rewrite this one as new GUID with a string as well. This is a silly optimization.
There was a problem hiding this comment.
I didn't write that line, but yeah i can be improved.
|
This is good, needs a bit of work. Please also update CHANGELOG. |
|
Are the changes okay or is there more work needed? |
There was a problem hiding this comment.
Make this look like all the other changelog items.
- Period at the end.
- No
(..). - Write the full class name where this is added, JNA is not just Win32.
|
Added some more comments. This is very close. Can you also please rebase/squash these commits so that this is mergeable. Thx. |
There was a problem hiding this comment.
You didn't write the whole thing, right? You should remove this or fish all the names from git history and add them too.
|
Feel free to reject this pull request, i have no time to finish it. |
|
Lets leave it open in case someone wants to. |
|
I closed this cause made a new PR for this, see-> #419 |
2 participants
I added the following items to the Win32 SetupApi
The JavaDocs are copied from MSDN, is this a legal problem?