Adding support for OpenGL functions#270
Adding support for OpenGL functions#270kc7bfi wants to merge 2 commits intojava-native-access:masterfrom kc7bfi:master
Conversation
|
Yes, the PR changes are all about tabs vs. spaces, check what the JNA code is and change your editor to those. It would be helpful, otherwise it's really hard to see history. I think it's a 2 spaces tab, but I could be wrong. Please update CHANGELOG. |
There was a problem hiding this comment.
Is there a better exception we can catch here so that the test is properly ignored when you don't have an NVidia card?
There was a problem hiding this comment.
The exception is only if something goes wrong. If the nVidia extensions are not supported then 0 is returned.
There was a problem hiding this comment.
So this is just to get the stacktrace? I think the test should expect that
function to return >= 0 and not catch any errors.
On Wed, Oct 2, 2013 at 12:34 PM, David Robison [email protected]:
In contrib/platform/test/com/sun/jna/platform/win32/OpenGL32UtilTest.java:
+import junit.framework.TestCase;
+
+/**
- * @author [email protected]
- */
+public class OpenGL32UtilTest extends TestCase {
+- public static void main(String[] args) {
junit.textui.TestRunner.run(OpenGL32UtilTest.class);- }
- public void testCountGpusNV() {
try {OpenGL32Util.countGpusNV();} catch (Exception e) {The exception is only if something goes wrong. If the nVidia extensions
are not supported then 0 is returned.—
Reply to this email directly or view it on GitHubhttps://github.com//pull/270/files#r6720402
.
dB. | Moscow - Geneva - Seattle - New York
code.dblock.org - @dblockdotorg http://twitter.com/#!/dblockdotorg -
artsy.net - github/dblock https://github.com/dblock
There was a problem hiding this comment.
OK, I'll make the change. David
There was a problem hiding this comment.
I committed and pushed the change. Do I need to do anything with the pull request?
|
Code looks good otherwise, I'll merge after your changes. |
|
I'm going to refork and retry the changes. It appears that my Eclipse was modifying the indentation/etc and I cannot seem to get back to where everything is as it was. Is there an easy way to restore my repository to the master without deleting and creating a new fork? |
|
Backup the local git repo so you don't lose changes. Then bring master back to be in sync with upstream JNA. Now you have a clean |
|
Reopened as #280. |
…access#270) Motivation: When a stream receives a STOP_SENDING frame, it should be able to keep receiving data. Modification: Update QuicheQuicChannel.handleWritableStreams() to handle Quiche.QUICHE_ERR_STREAM_STOPPED differently from other errors, and ignore it instead of throwing an exception and closing the stream. Result: Stream no longer gets closed and can receive more data. Co-authored-by: Norman Maurer <[email protected]>
2 participants
I have added code to expose some of the OpenGL functions. This was motivated by a need to determine the number of nVidia adapters present on a system. I had to make some changes to WinGDI.java and GDI32.java. I'm not sure why the pull request is attempting to replace the entire file, it may be due to indentation issues. Hope this is not a problem. I also removed a debug statmenet in the WinRas which was previously submitted.
David