Skip to content

Provide support for the Windows RAS32 API#267

Merged
dblock merged 3 commits intojava-native-access:masterfrom
kc7bfi:master
Sep 25, 2013
Merged

Provide support for the Windows RAS32 API#267
dblock merged 3 commits intojava-native-access:masterfrom
kc7bfi:master

Conversation

@kc7bfi
Copy link
Copy Markdown
Contributor

@kc7bfi kc7bfi commented Sep 23, 2013

I've provided new code to add support for Windows RAS32 API.

@dblock
Copy link
Copy Markdown
Member

dblock commented Sep 23, 2013

This looks great. Can you please add a line into CHANGES.md? Thx.

@dblock
Copy link
Copy Markdown
Member

dblock commented Sep 23, 2013

There're also a lot of tests missing, for things like RasGetCredentials. It's not always obvious how to write a test for something like this, but a negative test is useful: call it with some invalid parameter and expect that it returns an expected error, for example.

@kc7bfi
Copy link
Copy Markdown
Contributor Author

kc7bfi commented Sep 23, 2013

OK, I've added the line in CHANGES.md. I wasn't sure how to generate
tests without actually creating or dialing RAS phone book entries.

David R Robison
Open Roads Consulting, Inc.
103 Watson Road, Chesapeake, VA 23320
phone: (757) 546-3401
e-mail: [email protected]
web: http://openroadsconsulting.com
blog: http://therobe.blogspot.com
book:
http://www.xulonpress.com/bookstore/bookdetail.php?PB_ISBN=9781597816526

On Monday, September 23, 2013 4:01:20 PM, Daniel Doubrovkine (dB.)
wrote:

There're also a lot of tests missing, for things like
|RasGetCredentials|. It's not always obvious how to write a test for
something like this, but a negative test is useful: call it with some
invalid parameter and expect that it returns an expected error, for
example.

—
Reply to this email directly or view it on GitHub
#267 (comment).

This email communication (including any attachments) may contain confidential and/or privileged material intended solely for the individual or entity to which it is addressed.
If you are not the intended recipient, please delete this email immediately.

@kc7bfi
Copy link
Copy Markdown
Contributor Author

kc7bfi commented Sep 23, 2013

OK, I've added more tests, I think the pull request should be good now.
David

David R Robison
Open Roads Consulting, Inc.
103 Watson Road, Chesapeake, VA 23320
phone: (757) 546-3401
e-mail: [email protected]
web: http://openroadsconsulting.com
blog: http://therobe.blogspot.com
book:
http://www.xulonpress.com/bookstore/bookdetail.php?PB_ISBN=9781597816526

On Monday, September 23, 2013 4:05:37 PM, David R Robison wrote:

OK, I've added the line in CHANGES.md. I wasn't sure how to generate
tests without actually creating or dialing RAS phone book entries.

David R Robison
Open Roads Consulting, Inc.
103 Watson Road, Chesapeake, VA 23320
phone: (757) 546-3401
e-mail: [email protected]
web: http://openroadsconsulting.com
blog: http://therobe.blogspot.com
book:
http://www.xulonpress.com/bookstore/bookdetail.php?PB_ISBN=9781597816526

On Monday, September 23, 2013 4:01:20 PM, Daniel Doubrovkine (dB.) wrote:

There're also a lot of tests missing, for things like
|RasGetCredentials|. It's not always obvious how to write a test for
something like this, but a negative test is useful: call it with some
invalid parameter and expect that it returns an expected error, for
example.

—
Reply to this email directly or view it on GitHub
#267 (comment).

This email communication (including any attachments) may contain confidential and/or privileged material intended solely for the individual or entity to which it is addressed.
If you are not the intended recipient, please delete this email immediately.

@dblock dblock merged commit 8a4a7e1 into java-native-access:master Sep 25, 2013
@dblock
Copy link
Copy Markdown
Member

dblock commented Sep 25, 2013

Merged, thanks for contributing.

mstyura pushed a commit to mstyura/jna that referenced this pull request Sep 9, 2024
@normanmaurer
Fix test race introduced by 22dffdf (java-native-access#267)
43d8d31 
Motivation:

22dffdf added a testcase which had a race.

Modifications:

Remove the isDone() check as it is racy

Result:

Fix test-failure which can happen due the race
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kc7bfi @dblock