Added some more Win32 platform calls.#2
Merged
dblock merged 20 commits intojava-native-access:masterfrom Jul 11, 2011
Merged
Conversation
Member
|
This is great, but to merge this into JNA you need to do a few things.
|
Contributor
Author
|
Thanks for the feedback. I'll look in to making those changes in the next few weeks. Cheers, Luke |
…n32 interfaces still in the old project structure.
…other header files.
…etails to new files.
Member
There was a problem hiding this comment.
These are defined in WinNT.h, move to WinNT.java please.
Member
|
I am merging the changes, thank you. Please see my comments for a future pull and update Changes.md in the root. |
dblock
added a commit
that referenced
this pull request
Jul 11, 2011
Added some more Win32 platform calls.
Contributor
Author
|
Thanks for merging in this pull request and for the feedback. Updating Changes.md is still on my to-do list. Also I think next time I'll make my pull request smaller! Cheers, Luke |
Member
|
Cool, thanks Luke. My comments are minor, it takes some time to get used to this stuff. You're doing great. Congrats for your first commit to JNA! Billions of people use it :) |
matthiasblaesing
pushed a commit
to matthiasblaesing/jna
that referenced
this pull request
Aug 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some extra win32 platform calls.
There are only about two changes to Advapi32Util.java but for some reason its not merging cleanly. In that class I just changed registryGetStringValue() to accept REG_EXPAND_SZ. (I've seen some registry values that can switch between REG_SZ and REG_EXPAND_SZ so this simplifies the calling code).
Initially I put the additional structures into their own package but I'm happy to move them where ever.
Please let me know if you need any other changes.
Thanks,
Luke