RegisterWindowMessage#196
Conversation
which wraps registerWindowMessage, createWindow and createWindowEx.
|
Very nice. Now that you have a pull request you can fix the link in the CHANGES. And there will be a conflict in CHANGES as well as another branch got merged, so you'll need to resolve that first. Thank you. |
|
Perfect, great, merging. Small thing. In unit tests you're creating windows. I wonder if it needs a corresponding destroy window or we'll be leaking handles until the Java process is gone. |
|
Good question! In fact I don't know what maximum number of handles-per-process in Windows actually is. I remember back in 16 bit times it was rather small (like 1024 or so), but never have seen running out of HWND on Win32. If you like I can add a destruction code, but on the other hand, it would foil isolution of tests for Create and Destroy. What do you think? |
|
I think you should add the destruction code. Other people looking at tests as examples might think that it's ok not to destroy things you've created. |
|
Ok I will add the destruction code and commit to this branch. I assume that this will not block your possibility to merge again? |
|
Just open a new pull request after pushing the code. Thanks. |
…#196) Motivation: Peer verification is now configured as part of the QuicSslContextBuilder. Remove the unused QuicChannelOption. Modifications: - Remove unused QuicChannelOption Result: Code cleanup
3 participants
I request to merge this new functionality into your repo:
•New function mapping: RegisterWindowMessage
•New wrapper: User32Util for convenient use of RegisterWindowMessage, CreateWindow and CreateWindowEx.