Skip to content

Mapping functions required for global hotkeys#15

Merged
dblock merged 4 commits intojava-native-access:masterfrom
tulskiy:master
Jul 27, 2011
Merged

Mapping functions required for global hotkeys#15
dblock merged 4 commits intojava-native-access:masterfrom
tulskiy:master

Conversation

@tulskiy
Copy link
Copy Markdown
Contributor

@tulskiy tulskiy commented Jul 25, 2011

Hello, I've added mappings to several functions required for global hotkeys functionality:

  1. RegisterHotkey and UnregisterHotkey for windows in User32, including some tests.
  2. XGrabKey and XUngrabKey for X11, and also XSetErrorHandler to handle errors
  3. Several functions for Carbon library for Mac OSX. These are less documented because the Carbon documentation says I can not copy any part of it :(

I've tested these mappings in my own library, not with platform.jar, just decided to share them here.

@dblock
Copy link
Copy Markdown
Member

dblock commented Jul 26, 2011

Very good. Can you please also update CHANGES.md? I'll merge then.

@tulskiy
Copy link
Copy Markdown
Contributor Author

tulskiy commented Jul 27, 2011

Umm, I'm not that good with git-fu - my repo and upstream now diverged, what should I do? Make a merge from upstream and push a merge commit or rebase somehow?

@dblock
Copy link
Copy Markdown
Member

dblock commented Jul 27, 2011

I add the twall remote like this: git remote add twall [email protected]:twall/jna.git
Now you can do git pull twall master which updates your code
Make the changes, commit and push, it should automatically update this pull request

@tulskiy
Copy link
Copy Markdown
Contributor Author

tulskiy commented Jul 27, 2011

ok, I did a rebase from upstream and updated CHANGES.md. Hope it doesn't brake the git-magic.

Comment thread CHANGES.md
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A period is missing at the end of the sentence! :)

dblock added a commit that referenced this pull request Jul 27, 2011
Mapping functions required for global hotkeys
@dblock dblock merged commit 1ec8563 into java-native-access:master Jul 27, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants