Handle arrays in structures with differing size#1438
Merged
matthiasblaesing merged 1 commit intojava-native-access:masterfrom May 16, 2022
Merged
Conversation
libffi uses ffi_type structures to describe arrays and structures passed to native. JNA builds these structures and caches them using the associated classes as keys. For arrays this leads to the situation where only a single ffi_type was stored for all sizes of the same base type. This in turn causes wrong behavior in libffi.
matthiasblaesing
force-pushed
the
structure_differing_array_size
branch
from
a62ce02 to
ed019cc
Compare
Member
Author
matthiasblaesing
changed the title
dbwiddis
reviewed
May 13, 2022
Contributor
dbwiddis
left a comment
dbwiddis
left a comment
There was a problem hiding this comment.
Not having deep knowledge of the original issue I am hesitant to check 'approve' but I have reviewed the code and it all looks sane.
Member
Author
|
@dbwiddis thanks for having a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libffi uses ffi_type structures to describe arrays and structures passed
to native. JNA builds these structures and caches them using the
associated classes as keys. For arrays this leads to the situation where
only a single ffi_type was stored for all sizes of the same base type.
This in turn causes wrong behavior in libffi.