Increase Sspi#MAX_TOKEN_SIZE on Windows 8/Server 2012 and later#1398
Increase Sspi#MAX_TOKEN_SIZE on Windows 8/Server 2012 and later#1398dblock merged 1 commit intojava-native-access:masterfrom
Conversation
dbwiddis
force-pushed
the
maxtokensize
branch
from
52ed10e to
de853f3
Compare
|
I'm not that deep in the windows apis anymore, but if this is a Kerberos Token, it is generated by the KDC (in windows networks the domain controller). Wouldn't it make more sense to default to 48kB uncondionally? |
I think @dbwiddis is trying to match the default as documented on different versions of Windows. I prefer that. |
|
@JStroom is this what you're looking for or something else? |
Indeed I was. However, Windows 7/Server 2008 are both EOL now, so I am fine just updating to the new default. |
|
Hi @dbwiddis, Yes that is exactly what I was looking for. I was planning to create a pull request after the weekend, but this is better than what I had in mind. Thanks! |
4 participants
Fixes #1396. See also #291.
Alternately, we could read the
MaxTokenSizeregistry entry value atHKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa\Kerberos\Parametersif it exists, and default to these values otherwise, but that's way too complex to put in an initialization.