Skip to content

Add RegLoadAppKeyW #1377

Merged
matthiasblaesing merged 2 commits intojava-native-access:masterfrom
mfilippov:mf-reg-open-app
Aug 24, 2021
Merged

Add RegLoadAppKeyW #1377
matthiasblaesing merged 2 commits intojava-native-access:masterfrom
mfilippov:mf-reg-open-app

Conversation

@mfilippov
Copy link
Copy Markdown
Contributor

@mfilippov mfilippov commented Aug 23, 2021

Also, fix source compatibility with Java 6. It blocks my local test run.

matthiasblaesing
matthiasblaesing requested changes Aug 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@matthiasblaesing matthiasblaesing left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - looks sane to me. I left an inline comment about the naming of the function and please remove the darwin-aarch64.jar.

And one additional request: Please add a feature entry for the newly bound function in CHANGES.md.

Comment thread contrib/platform/src/com/sun/jna/platform/win32/Advapi32.java Outdated
@mfilippov mfilippov force-pushed the mf-reg-open-app branch 3 times, most recently from b741bbb to 96965e7 Compare August 23, 2021 18:51
@mfilippov
Copy link
Copy Markdown
Contributor Author

mfilippov commented Aug 23, 2021

@matthiasblaesing Do I need to add the registryLoadAppKey method in CHANGES.md or Advapi32.RegLoadAppKey is enough?

@matthiasblaesing
Copy link
Copy Markdown
Member

matthiasblaesing commented Aug 23, 2021

I would mention both. If space is an issue the prefix com.sun.jna.platform. is commonly shorted to c.s.j.p..

@mfilippov
Copy link
Copy Markdown
Contributor Author

mfilippov commented Aug 23, 2021

@matthiasblaesing, it is ready.

matthiasblaesing
matthiasblaesing reviewed Aug 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good. Last change request: Please rebase the changes onto current master. Sunday night the 5.9.0 release was cut. The git diff does not recognize the merge conflict, but it needs to be resolved (merging as is would add the change description to 5.9.0, but it will become part of 5.10.0).

@matthiasblaesing
Copy link
Copy Markdown
Member

matthiasblaesing commented Aug 24, 2021

Sorry, the CHANGES.md is still wrong. The new change log entry is in the section for the released 5.9.0 version, but should be in the features subsection of the "Next Release (5.10.0)" section.

@mfilippov
Copy link
Copy Markdown
Contributor Author

mfilippov commented Aug 24, 2021

@matthiasblaesing I misunderstand it, sorry. I updated CHANGES.md

matthiasblaesing
matthiasblaesing approved these changes Aug 24, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you.

@matthiasblaesing matthiasblaesing merged commit 030411b into java-native-access:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mfilippov @matthiasblaesing