HKEY_CURRENT_USER_LOCAL_SETTINGS should be supported#1336
Conversation
dbwiddis
left a comment
There was a problem hiding this comment.
Looks good. Please add an entry to CHANGES
|
HI, @Dani-Hub I'm ready to merge your three pull requests, but need some admin changes from you first:
|
|
Hi, |
|
Some instructions here. To change it for all commits anywhere: There are other ways to change for just a single repository or a single commit if desired. There are a few reasons why this is a good practice and why we do that here:
|
|
OK, I have now changed user.name and user.email for the local repository where my contribution came from. It is not clear to me, though, when this manifests here. I can of-course just make a pull-request of the changes.md and we'll see what happens. |
|
If you squash the commits it should take the later settings. Or just add a new commit and I can squash them. Thanks! |
|
To be clear, just add a new commit to the branch you've already submitted for this PR. You do not need to do a new PR. |
|
Hmmh, do you notice a difference? I'm not, albeit I double-checked that for that local repository user.name and user.email have been adjusted to the intended values. |
|
I don't understand what this build failure is going to tell me: https://travis-ci.org/github/java-native-access/jna/builds/767460410. Could you please help? |
|
Don't worry about that build failure, it has nothing to do with your commit. It may be a transient error. |
Yes, your most recent commit has your full name. I'll squash the commits and merge this PR. Can you do the same for the other two PRs? |
|
Sure, will do in a minute - thanks for the guidance! |
Starting with Windows 7, Windows added the additional HKEY constant HKEY_CURRENT_USER_LOCAL_SETTINGS (see predefined-key) whose underlying integral value has the value 0x80000007 (Source: Visual Studio 2017, header <winreg.h>. This constant is currently missing in the existing set of HKEY_* constants in com.sun.jna.platform.win32.WinReg. This adds the new static field HKEY_CURRENT_USER_LOCAL_SETTINGS to the set of the other HKEY constants in WinReg.
b15e37f to
4b4df23
Compare
|
BTW the travis test failure is because the download source of the binaries changed their HTML which breaks our script parsing. I'll fix that in a different PR. You can ignore it. |
Starting with Windows 7, Windows added the additional HKEY constant HKEY_CURRENT_USER_LOCAL_SETTINGS (see predefined-key) whose underlying integral value has the value 0x80000007 (Source: Visual Studio 2017, header <winreg.h>. This constant is currently missing in the existing set of HKEY_* constants in com.sun.jna.platform.win32.WinReg. This adds the new static field HKEY_CURRENT_USER_LOCAL_SETTINGS to the set of the other HKEY constants in WinReg.