Add partial support for future values of LOGICAL_PROCESSOR_RELATIONSHIP#1327
Add partial support for future values of LOGICAL_PROCESSOR_RELATIONSHIP#1327dbwiddis merged 2 commits intojava-native-access:masterfrom
Conversation
|
I admit I have only glanced over, but just a thought - would it make sense to return a generic value holding the raw memory value when an unsupported relationship is encountered? That way people would at least get a value and not blow with an exception - especially as it is now proven, that new relationships are possible. Possible name "UNKNOWN_RELATIONSHIP". |
Heh. I actually had previously implemented a similar workaround with exactly that name and am happy to go that route. My reasoning to not submit it that way was that after the new code was in we'd never use that structure again. We'll still have the two leading |
|
Actually such a getter isn't needed, the structure itself already has a |
|
Looks sane to me. |
2 participants
See #1324 for more details.
This PR implements new
LOGICAL_PROCESSOR_RELATIONSHIPenum values which are present in current Windows Insider builds and currently throw anIllegalStateExceptionwhen instantiating aSYSTEM_LOGICAL_PROCESSOR_INFORMATION_EXstructure from a pointer.A complete implementation will require updating the
NUMA_NODE_RELATIONSHIPstructure and javadocs, and will be submitted later once the new API documentation is available.