Skip to content

Ensure memory object backing TOKEN_USER is retained until account extraction is done#1325

Closed
matthiasblaesing wants to merge 1 commit intojava-native-access:masterfrom
matthiasblaesing:token_fence
Closed

Ensure memory object backing TOKEN_USER is retained until account extraction is done#1325
matthiasblaesing wants to merge 1 commit intojava-native-access:masterfrom
matthiasblaesing:token_fence

Conversation

@matthiasblaesing
Copy link
Copy Markdown
Member

No description provided.

@matthiasblaesing
Copy link
Copy Markdown
Member Author

@dbwiddis it would be good if this would be tested in an environment, where the original issue was visible. It should be save to read a single byte from the beginning of the structure, as there is no smaller datatype in C.

@matthiasblaesing
Copy link
Copy Markdown
Member Author

Please see #1326 for a (most probably) better solution.

@dbwiddis
Copy link
Copy Markdown
Contributor

I've already updated my own project's snapshot with this fix and asked the original issue reporters to test. Meanwhile I'll spin up an Azure VM today and see if I can reproduce the problem and then test the #1326 fix.

@dblock
Copy link
Copy Markdown
Member

dblock commented Mar 13, 2021

Please see #1326 for a (most probably) better solution.

This nice work.

@matthiasblaesing
Copy link
Copy Markdown
Member Author

Closed in favor of #1326

@dbwiddis
Copy link
Copy Markdown
Contributor

As a follow up, the users reporting this original issue tested the equivalent of this fix and could not reproduce the problem, which suggests the #1326 fix will also work.

@matthiasblaesing matthiasblaesing deleted the token_fence branch October 20, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants