Handle 0-length domain names in Advapi32Util#getAccountBySid#1322
Merged
dbwiddis merged 2 commits intojava-native-access:masterfrom Mar 6, 2021
Merged
Handle 0-length domain names in Advapi32Util#getAccountBySid#1322dbwiddis merged 2 commits intojava-native-access:masterfrom
dbwiddis merged 2 commits intojava-native-access:masterfrom
Conversation
Contributor
Author
|
This sample code from MSDN does a single call using MAX_NAME of 256 for both fields (which apparently works without null terminator because it's a fixed length array). One potential needed change is to test for the zero-length domain name when building the |
dbwiddis
force-pushed
the
accountbysid
branch
2 times, most recently
from
4b7f79a to
c846543
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rare/transient situations, such as UAC elevation or other SYSTEM account situations, the domain name can be an empty string. In this case
cchDomainNameis set to 0 and a zero-length array causes the function call to fail with an incorrect parameter. See oshi/oshi#1551 and oshi/oshi#637 for examples of failure symptoms.Rather than adding code to handle the special case, we can simplify the code to avoid the initial call to get length, and prevent this error by using the max possible string lengths.
GetUserNamedocs indicate:UNLEN is 256. The max local domain length (DNLEN) is 15, but to be conservative I used the max FQDN length of 255.