Skip to content

Add mapping for X11 generic events#1260

Closed
lafoletc wants to merge 3 commits intojava-native-access:masterfrom
lafoletc:Generic_events
Closed

Add mapping for X11 generic events#1260
lafoletc wants to merge 3 commits intojava-native-access:masterfrom
lafoletc:Generic_events

Conversation

@lafoletc
Copy link
Copy Markdown
Contributor

@lafoletc lafoletc commented Oct 30, 2020

@lafoletc lafoletc changed the title Add generic events Add X11 generic events Oct 31, 2020
@matthiasblaesing
Copy link
Copy Markdown
Member

Could you please point to the definition/headerfiles for the structures? That would help to review.

For the commit please check the author settings. The committer email looks sane, but for the author name only your firstname is set. To fix the existing commits, please squash them and update the author information while doing so.

Please also add an enhancement entry to the CHANGES.md entry. Have a look at the existing entries as template.

Thanks.

@lafoletc lafoletc changed the title Add X11 generic events Add mapping for X11 generic events Nov 2, 2020
@dbwiddis
Copy link
Copy Markdown
Contributor

dbwiddis commented Nov 2, 2020

The structures are already defined in X11 (Display is just a decorated PointerType), and match here.

Is it possible to create a test case to exercise these functions? Looks like sample code at the above manpage link.

@matthiasblaesing
Copy link
Copy Markdown
Member

Merged via 8f17bdd

I finished the squash and fixed a remaining problem checkstyle complained about.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants