Add CallWindowProc to User32#1242
Merged
dbwiddis merged 1 commit intojava-native-access:masterfrom Aug 3, 2020
Merged
Conversation
Contributor
|
Thanks for your contribution, @heldplayer. A few requests:
|
a62e65e to
94c98c0
Compare
Contributor
Author
|
I'm hoping the test location is adequate in User32WindowMessagesTest, as it already had pretty much everything set up to test the function. Otherwise I would have had to create a test case that would have copied a big part of it. If you'd prefer me to go down that route instead, or have a better idea how I should implement this test, feel free to let me know :) |
Contributor
|
Thanks, looks good to me. I'll wait a day in case anyone else has comments and then merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method documentation: https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-callwindowproca
First time contributing here, not sure what a test for this method would look like so any pointers would be appreciated ^^