Add mappings for AIX Perfstat library#1217
Add mappings for AIX Perfstat library#1217dbwiddis merged 1 commit intojava-native-access:masterfrom
Conversation
|
For ease of review:
You may find it convenient to inspect the contents of the structures using util classes on this project which were the basis for the test cases and are producing "sane" output. I did update the |
|
And, apparently I can't use the static method to load the interface in Java 6, so I'll have to think about a better way to do that. Suggestions welcome. |
0f84ef8 to
feb986f
Compare
59ac743 to
08fb97d
Compare
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks good to me, with minimal comment inline. Did you manage to run the unittests on aix?
|
Deleted the pad and everything still works (exact copies of the files from this PR in my own project, with only package name/imports changed). Will make the other requested changes. |
|
One other note: the separate shared object loader class is necessary on Java 6, but a static interface method works in Java 8. It's also a potential solution to update |
The aix optimization could be done later. For now it would be good to make SharedObjectLoader package private, that way it is not exposed outside jna-platform and we are free to change it as necessary. |
|
License added and shared loader made package private. Should be ready to merge. |
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane. Thank you.
Adds mappings to several structures and functions in AIX Perfstat library. Documentation at https://www.ibm.com/support/knowledgecenter/ssw_aix_71/performancetools/idprftools_perfstat.html