Remove too-strict filestore available size test#1203
Merged
matthiasblaesing merged 1 commit intojava-native-access:masterfrom Jun 2, 2020
Merged
Remove too-strict filestore available size test#1203matthiasblaesing merged 1 commit intojava-native-access:masterfrom
matthiasblaesing merged 1 commit intojava-native-access:masterfrom
Conversation
Member
|
Sounds sane. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test that usable space equals available space on a filestore is too strict, as it can fail in a race condition between fetching
statvfsand getting the same information from core Java:Failed test:
In theory we could test for something "close" but any change threshold we choose would be arbitrary. Given the previous line checks equality of total space, which should not change, I think this test can simply be removed.