LARGE_INTEGER needs to populate both union fields#1196
Merged
matthiasblaesing merged 2 commits intojava-native-access:masterfrom May 17, 2020
Merged
LARGE_INTEGER needs to populate both union fields#1196matthiasblaesing merged 2 commits intojava-native-access:masterfrom
matthiasblaesing merged 2 commits intojava-native-access:masterfrom
Conversation
Contributor
Author
|
Fixed by overriding |
Member
|
Looks good to me. Thank you. |
Contributor
Author
|
My CI just pointed out an inconsistency with other methods. Should the overridden read call |
Member
|
I don't see a problem. Structure#read basicly cycles through all structure fields and calls readField on them. Union overrides this and blocks reads from fields, that don't belong to the current selected type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on the mailing list. Initial commit is a failing test case.