[GITHUB-1118] Ensure union with floating point and integer member is passed in integer register#1122
Merged
matthiasblaesing merged 2 commits intojava-native-access:masterfrom Sep 19, 2019
Conversation
Member
Author
matthiasblaesing
force-pushed
the
x86-64-by-value-union
branch
from
1ece7cd to
a4995c4
Compare
Member
Author
|
@twall ping? |
…ed union by value
…passed in integer register System V x86-64 ABI requires, that in a union aggregate, that contains Integer and Double members, the parameters must be passed in the integer registers. I.e. in the case where the java side declares double and int members, the wrong FFI Type would be found, because the doubles size is larger than the int member, but the wrong parameter passing method would be used.
matthiasblaesing
force-pushed
the
x86-64-by-value-union
branch
from
a4995c4 to
678d82a
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System V x86-64 ABI requires, that in a union aggregate, that contains
Integer and Double members, the parameters must be passed in the integer
registers. I.e. in the case where the java side declares double and int
members, the wrong FFI Type would be found, because the doubles size is
larger than the int member, but the wrong parameter passing method would
be used.