Skip to content

Code review changes.#11

Merged
dblock merged 3 commits intojava-native-access:masterfrom
tmyroadctfig:master
Jul 13, 2011
Merged

Code review changes.#11
dblock merged 3 commits intojava-native-access:masterfrom
tmyroadctfig:master

Conversation

@tmyroadctfig
Copy link
Copy Markdown
Contributor

No description provided.

dblock added a commit that referenced this pull request Jul 13, 2011
@dblock dblock merged commit 94097d4 into java-native-access:master Jul 13, 2011
mstyura pushed a commit to mstyura/jna that referenced this pull request Sep 9, 2024
…nd(...) (java-native-access#11)

Motivation:

We need to carefully handle the scheduling of timeouts and calling of quiche_conn_send to follow the pattern outlined by quiche:

* https://docs.rs/quiche/0.6.0/quiche/struct.Connection.html#method.send
* https://docs.rs/quiche/0.6.0/quiche/#generating-outgoing-packets

Modifications:

- Rename methods to make it easier to understand the code
- Schedule timeouts at the correct time
- Call quiche_conn_send on the correct time
- Add some comments to make it easier to understand the code and the state-machine.

Result:

Correctly use quiche API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants