Code review changes.#11
Merged
dblock merged 3 commits intojava-native-access:masterfrom Jul 13, 2011
Merged
Conversation
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
…nd(...) (java-native-access#11) Motivation: We need to carefully handle the scheduling of timeouts and calling of quiche_conn_send to follow the pattern outlined by quiche: * https://docs.rs/quiche/0.6.0/quiche/struct.Connection.html#method.send * https://docs.rs/quiche/0.6.0/quiche/#generating-outgoing-packets Modifications: - Rename methods to make it easier to understand the code - Schedule timeouts at the correct time - Call quiche_conn_send on the correct time - Add some comments to make it easier to understand the code and the state-machine. Result: Correctly use quiche API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.