[GITHUB-1087] Fix wrong calls to Structure#toArray with zero sized arrays#1088
Merged
matthiasblaesing merged 1 commit intojava-native-access:masterfrom Apr 26, 2019
Merged
Conversation
Member
Author
|
@hc-codersatlas please check this PR. It is a partial revert of your changeset (performance optimization by using a zero sized array in Collection#toArray. I plan to do a patch release next weekend, as this is a regression. Here is a test build: |
matthiasblaesing
force-pushed
the
github-1087
branch
from
41f072b to
90b8885
Compare
Contributor
|
Good find. Thanks. Didn't notice the Structure. All good. |
dbwiddis
reviewed
Apr 26, 2019
|
|
||
| Bug Fixes | ||
| --------- | ||
| * [#1087](https://github.com/java-native-access/jna/pull/1087): Fix wrong calls to Structure#toArray with zero sized arrays - [@matthiasblaesing](https://github.com/matthiasblaesing). |
Contributor
There was a problem hiding this comment.
Should this be 1088? (Yay, I found something to comment on. I did look over the PR and otherwise think it looks good.)
Member
Author
There was a problem hiding this comment.
If there is an issue open for a changeset, I'm referencing that. If there is no issue, then it is the PR that brought the change in. In this case the original PR is #1087 and replaces an issue.
Thank you for your review!
…rays As a performance optimization calls to Collections#toArray where changed from providing a correctly sized array to using a zero sized array. See 07f3ce0 The change is invalid if the object toArray is called on is a Structure, the calls just look the same. This changeset is a partial revert of the above mentioned commit. Closes: java-native-access#1087
matthiasblaesing
force-pushed
the
github-1087
branch
from
90b8885 to
b749db5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a performance optimization calls to Collections#toArray where changed
from providing a correctly sized array to using a zero sized array.
See 07f3ce0
The change is invalid if the object toArray is called on is a Structure,
the calls just look the same. This changeset is a partial revert of the
above mentioned commit.
Closes: #1087