Fixed Advapi32Util getAccountBySid for remote machines#1068
Closed
nirud wants to merge 1 commit intojava-native-access:masterfrom
nirud:Advapi32Util-getAccountBySid-fix
Closed
Fixed Advapi32Util getAccountBySid for remote machines#1068nirud wants to merge 1 commit intojava-native-access:masterfrom nirud:Advapi32Util-getAccountBySid-fix
nirud wants to merge 1 commit intojava-native-access:masterfrom
nirud:Advapi32Util-getAccountBySid-fix
Conversation
Member
|
Thank you for the work. Merged as b5b875f (I added CHANGES.md entry for this). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advapi32Util.getAccountBySid(String systemName, PSID sid)did not pass the parameter systemName to LookupAccountBySid calls.It always passed null and got the account from the local machine.
There are no tests which tests the Advapi32 API involving a second remote machine therefor no tests were added or changed for this pull request.