Add GetLogicalProcessorInformationEx function#1064
Closed
dbwiddis wants to merge 3 commits intojava-native-access:masterfrom
Closed
Add GetLogicalProcessorInformationEx function#1064dbwiddis wants to merge 3 commits intojava-native-access:masterfrom
dbwiddis wants to merge 3 commits intojava-native-access:masterfrom
Conversation
Member
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks pretty good. I left two comments inline. Thank you.
|
|
||
| WinBase.EnumResTypeProc ertp = new WinBase.EnumResTypeProc() { | ||
|
|
||
| @Override |
Member
There was a problem hiding this comment.
Any reason for removing the @OverRide annotations? These are valid overrides.
Contributor
Author
There was a problem hiding this comment.
My IDE flagged this as an error, and stubbornly wouldn't format my other code until I eliminated the errors.
Turns out I had my compiler level on my JNA project set to 1.5 (where this was disallowed). I've switched it to 1.6. I'll put those overrides back.
Member
|
Merged via e0d5537. I widened the method signature from Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on Windows Server 2016 with 80 logical cores (successfully read 2-element group relationship array) as well as 32-bit Win7 and 64-bit Win10. Further discussion on JNA mailing list.