WinXP Compatibility for PdhUtil#PdhLookupPerfNameByIndex#1052
Merged
matthiasblaesing merged 1 commit intojava-native-access:masterfrom Jan 8, 2019
Merged
WinXP Compatibility for PdhUtil#PdhLookupPerfNameByIndex#1052matthiasblaesing merged 1 commit intojava-native-access:masterfrom
matthiasblaesing merged 1 commit intojava-native-access:masterfrom
Conversation
Member
|
Thank you - looks sane. |
Contributor
Author
|
Ugh, missed asking you to hold on this by a few hours. Doing more testing, discovered it doesn't quite fix the problem: the XP call that returns insufficient buffer isn't guaranteed to provide the new size... the docs give an either/or.
I need to wrap the XP fallback attempt in a loop that increases the buffer size until success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion on JNA mailing list. WinXP requires non-null buffer and non-zero size for PdhLookupPerfNameByIndex. But we can't always set a too-small buffer for Vista+ as the returned size is not reliable without the null.
This method should bypass the error conditional (more quickly over time with branch prediction) on modern OS's but provide XP compatibility with a third call if required.
Other ways to address this: