Pass systemName parameter of Advapi32Util.getAccountBySid to native functions

nilsrudolph · matthiasblaesing · commit b5b875f03cb4 · 2019-02-21T20:53:25.000+01:00
diff --git a/CHANGES.md b/CHANGES.md
@@ -13,6 +13,7 @@ Features
 * [#1064](https://github.com/java-native-access/jna/pull/1064): Add `c.s.j.p.win32.Kernel32.GetLogicalProcessorInformationEx` function, convenience Util method and supporting structures - [@dbwiddis](https://github.com/dbwiddis).
 * [#1065](https://github.com/java-native-access/jna/pull/1065): Add `c.s.j.p.win32.PowrProf#CallNTPowerInformation` and supporting structures - [@dbwiddis](https://github.com/dbwiddis).
 * [#1063](https://github.com/java-native-access/jna/pull/1063): Enhance `c.s.j.p.win32.User32` and associated classes to support keyboard related functionality. - [@kevemueller](https://github.com/kevemueller).
+* [#1068](https://github.com/java-native-access/jna/pull/1068): `c.s.j.p.win32.Advapi32Util.getAccountBySid(String systemName, PSID sid)` ignored parameter instead of passing it to the native function - [@nirud](https://github.com/nirud).
 
 Bug Fixes
 ---------
diff --git a/contrib/platform/src/com/sun/jna/platform/win32/Advapi32Util.java b/contrib/platform/src/com/sun/jna/platform/win32/Advapi32Util.java
@@ -263,7 +263,7 @@ public static Account getAccountBySid(String systemName, PSID sid) {
 		IntByReference cchDomainName = new IntByReference();
 		PointerByReference peUse = new PointerByReference();
 
-		if (Advapi32.INSTANCE.LookupAccountSid(null, sid, null, cchName, null,
+		if (Advapi32.INSTANCE.LookupAccountSid(systemName, sid, null, cchName, null,
 				cchDomainName, peUse)) {
 			throw new RuntimeException(
 					"LookupAccountSidW was expected to fail with ERROR_INSUFFICIENT_BUFFER");
@@ -278,7 +278,7 @@ public static Account getAccountBySid(String systemName, PSID sid) {
 		char[] domainName = new char[cchDomainName.getValue()];
 		char[] name = new char[cchName.getValue()];
 
-		if (!Advapi32.INSTANCE.LookupAccountSid(null, sid, name, cchName,
+		if (!Advapi32.INSTANCE.LookupAccountSid(systemName, sid, name, cchName,
 				domainName, cchDomainName, peUse)) {
 			throw new Win32Exception(Kernel32.INSTANCE.GetLastError());
 		}
