Fix free_callback JNI weak reference leak

xiezhaokun · xiezhaokun · commit 4bf9f92aa4b5 · 2024-01-09T15:03:03.000+08:00
diff --git a/native/callback.c b/native/callback.c
@@ -154,7 +154,7 @@ create_callback(JNIEnv* env, jobject obj, jobject method,
   for (i=0;i < argc;i++) {
     int jtype;
     jclass cls = (*env)->GetObjectArrayElement(env, arg_classes, i);
-    if ((cb->conversion_flags[i] = get_conversion_flag(env, cls)) != CVT_DEFAULT) {
+    if (direct && ((cb->conversion_flags[i] = get_conversion_flag(env, cls)) != CVT_DEFAULT)) {
       cb->arg_classes[i] = (*env)->NewWeakGlobalRef(env, cls);
       cvt = 1;
     }

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ create_callback(JNIEnv* env, jobject obj, jobject method,`
`154`	`154`	`for (i=0;i < argc;i++) {`
`155`	`155`	`int jtype;`
`156`	`156`	`jclass cls = (*env)->GetObjectArrayElement(env, arg_classes, i);`
`157`		`- if ((cb->conversion_flags[i] = get_conversion_flag(env, cls)) != CVT_DEFAULT) {`
	`157`	`+ if (direct && ((cb->conversion_flags[i] = get_conversion_flag(env, cls)) != CVT_DEFAULT)) {`
`158`	`158`	`cb->arg_classes[i] = (*env)->NewWeakGlobalRef(env, cls);`
`159`	`159`	`cvt = 1;`
`160`	`160`	`}`