[r2dbc-mysql] Fix getColumnMetadatas() of JasyncMetadata
#391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the issue and contribution. If possible, consider adding a test similar to: https://github.com/jasync-sql/jasync-sql/blob/master/r2dbc-mysql/src/test/java/com/github/jasync/r2dbc/mysql/integ/JasyncR2dbcIntegTest.kt Hopefully this will prevent future regression. |
Contributor
Author
|
@oshai Ok, I'll try to add commits for tests soon. |
Contributor
Author
|
@oshai I added a test which failed before this PR and passes now. |
Contributor
|
Thanks for contributing! |
Contributor
|
Releasing it in 2.1.24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #390.
Also, I modified the way to build a map of
ColumnMetadata(usingreversed()). Because originally the doc about method implementation (getColumnMetadata()andcontains()) of r2dbc interfaceRowMetadatawhich saysWhen a get method contains several columns with same name, then the value of the first matching column will be returnedhas been potentially violated (the last is used, not the first). Although this is meaningless because currently the only implemented method ofColumnMetadataisgetName().