Take this from an isolated script context #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully, this fixes jashkenas#2827.
3 tasks
|
@lohriialo and other ExtendScript users: until this is merged and released, you can just use the version D that I provided in #2827. It is equivalent to Underscore 1.9.2, but with the current fix as well as the fix from #2829. |
|
I have a feeling like some overzealous linters may complain about the "insecure" use of |
|
Thanks @jashkenas. At least the project's own linter doesn't complain. |
jgonggrijp
added a commit
to jgonggrijp/underscore
that referenced
this pull request
Mar 28, 2020
jgonggrijp
added a commit
to jgonggrijp/underscore
that referenced
this pull request
Mar 29, 2020
jgonggrijp
added a commit
that referenced
this pull request
Mar 30, 2020
The "this is undefined" warning has been completely eliminated by #2831 so the parameter isn't needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2827, in a way that will continue to work after the rollup conversion from #2826. As a bonus, it will also stop rollup from complaining about
thisbeing undefined at module scope.@lohriialo this is version D, but with a cleaner commit history.
@jashkenas it might be possible to skip the
selfandglobalchecks and just always rely onFunction('return this')(), but I'll leave that as an optional future step.