-
Notifications
You must be signed in to change notification settings - Fork 2k
Docs fixes #4707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs fixes #4707
Conversation
…he other examples the label signifies the command to be run
…n for user clicks on links; opening and closing Try CoffeeScript doesn’t count as a new history entry, and closing it retrieves the previous URL
lydell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what to review here, really. You know the website best @GeoffreyBooth.
| .main blockquote { | ||
| .main li p, .main li li, .main li blockquote { | ||
| font-size: 1em; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels more like a band-aid than a proper fix, but whatever. It works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know. I feel dirty writing it. But I have an aversion to rem and px units, because long ago they were bad for accessibility, but probably aren’t anymore.
|
This PR is mostly to double-check I didn’t break anything, since several recent commits did. And to clear that you both are okay with these changes. |
|
A few teeny adjustments:
... so that the boxes slim down a little.
|
|
@jashkenas I’ve applied your notes, with a few caveats (let’s discuss):
|
|
Looking good!
Otherwise, looks great to me. Please merge. |
pushState#4704: Back/forward not behaving as expected. Now new browser history items (which are cycled through by back and forward) only happen for user clicks on links; opening and closing Try CoffeeScript doesn’t count as a new history entry, and closing it retrieves the previous URL. The URLs still change on scroll, but scrolling doesn’t add to the browser history.<code>element, to avoid misaligned baseline.<head>.http://rawgit.com/GeoffreyBooth/coffeescript/docs-fixes/docs/v2/