Skip to content

Add GTK/OpenGL example#100

Merged
jaseg merged 3 commits intojaseg:masterfrom
trin94:master
Jan 2, 2020
Merged

Add GTK/OpenGL example#100
jaseg merged 3 commits intojaseg:masterfrom
trin94:master

Conversation

@trin94
Copy link
Copy Markdown
Contributor

@trin94 trin94 commented Jan 2, 2020

Copy link
Copy Markdown
Contributor

@McSinyx McSinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the Gist marked as DEPRECATED though?

Edit: sorry I missed the issue reference; when #99 is fixed, could the GTK example be updated to be, ehm, not deprecated?

sys.exit(app.exec_())

PyGtk embedding
PyGObject embedding
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the next line should be edited to match the length of this header.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out 😃 See 69337f8

@trin94
Copy link
Copy Markdown
Contributor Author

trin94 commented Jan 2, 2020

Why is the Gist marked as DEPRECATED though?

Edit: sorry I missed the issue reference; when #99 is fixed, could the GTK example be updated to be, ehm, not deprecated?

I plan to add an example once #99 is fixed 😃

Edit: I removed the deprecation warning in the description as there is no alternative way to render it into a widget yet. Instead I added a comment that the API is deprecated.

@jaseg jaseg merged commit 56c99a3 into jaseg:master Jan 2, 2020
@jaseg
Copy link
Copy Markdown
Owner

jaseg commented Jan 2, 2020

Thank you for the example! 😄

jaseg pushed a commit that referenced this pull request Jan 3, 2020
* Add GTK/OpenGL example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants