Repository navigation
Commit be4cb3e
Yaron de Leeuw
remove some redunancy in _BaseAxes
While working on matplotlib#1460, I've found that the `__init__` of `_BaseAxes`
takes some redundant arguments. Of the 7 arguments it takes,
3 (`xscale, yscale, label`) can be removed without harm, because
they are automatically used in `update(kwargs)` (they have matching `set_`
methods). Another two have different names as setters: `frameon` == `frame_on`
and `axisbg` ~ `axis_bgcolor`. Note that the later are mispelled, as they
refer to axes and not axis. The following call is actually legal:
plt.subplot(111, axisbg='green', axis_bgcolor='red')
I do not know what to do with the other two arguments. (`sharex` `sharey`)
I've tried to remove this redunancy, keeping the old defaults
intact, and without breaking the api. My opinion is that axisbg and frameon
should be reomved, but api changes and deprectations are above my level.
See also issue matplotlib#14601 parent 7a9f234 commit be4cb3e
1 file changed
Lines changed: 9 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
329 | 329 | | |
330 | 330 | | |
331 | 331 | | |
332 | | - | |
333 | | - | |
334 | | - | |
335 | 332 | | |
336 | 333 | | |
337 | 334 | | |
| |||
412 | 409 | | |
413 | 410 | | |
414 | 411 | | |
415 | | - | |
| 412 | + | |
| 413 | + | |
416 | 414 | | |
417 | 415 | | |
418 | 416 | | |
| |||
422 | 420 | | |
423 | 421 | | |
424 | 422 | | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
425 | 426 | | |
426 | 427 | | |
427 | | - | |
428 | | - | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
429 | 432 | | |
430 | 433 | | |
431 | 434 | | |
432 | | - | |
433 | 435 | | |
434 | 436 | | |
435 | 437 | | |
| |||
443 | 445 | | |
444 | 446 | | |
445 | 447 | | |
446 | | - | |
447 | | - | |
448 | | - | |
449 | | - | |
450 | 448 | | |
451 | 449 | | |
452 | 450 | | |
| |||
0 commit comments