docs: consider to add @keyv/lru to the official repository list#61
Closed
e0ipso wants to merge 1 commit intojaredwray:masterfrom
Closed
docs: consider to add @keyv/lru to the official repository list#61e0ipso wants to merge 1 commit intojaredwray:masterfrom
e0ipso wants to merge 1 commit intojaredwray:masterfrom
Conversation
Contributor
Author
|
If you want to proceed you'll need to add me as a collaborator in the Additionally we may want to drop the mention of |
e0ipso
changed the title
1 similar comment
Contributor
|
Thanks for this. Unfortunately I'm really busy on a paid project at the moment to properly look through this. Feel free to add it as a third party adapter for now, and I'll look at including it as an official adapter as soon as I'm able to. |
Contributor
Author
|
Thanks anyways. Do you want me to send you a reminder in a couple of weeks?
I know that's useful for me, otherwise I forget 😋
…On Tue, Jun 19, 2018, 7:48 AM Luke Childs ***@***.***> wrote:
Thanks for this. Unfortunately I'm really busy on a paid project at the
moment to properly look through this.
Feel free to add it as a third party adapter for now, and I'll look at
including it as an official adapter as soon as I'm able to.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#61 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABFoqmvSA7GJ2_HOyPOUMUjXwGPenVwPks5t-JCagaJpZM4Upwsi>
.
|
Contributor
|
Yeah, feel free to ping me in this thread. It may be more like 3 or 4 weeks though. |
Contributor
Author
|
@lukechilds my reminder to ping you about the just went off. Do you think you'll have time to look into it? |
Contributor
|
@e0ipso Thanks for your patience, the paid project is taking a little longer than expected to launch, but it's close! I expect to be able to go back to OSS part time within the next 2 weeks. |
Contributor
Author
|
Thanks for looping back! I don't have an issue setting an alarm for 2 weeks. Thanks for the OSS work. |
Contributor
Author
|
@lukechilds the alarm for this went off today after 2 weeks. ;-) |
Contributor
|
@e0ipso Apologies to keep stringing you along, still not quite finished with the paid work, I'm really hoping to get it wrapped up soon. |
Contributor
Author
|
@lukechilds paid work pays bills. Keep doing it. This can wait. |
Contributor
|
@e0ipso ok so it's looking like I will finally get around to this soon 😆 I've booked in two weeks holiday starting next week which I really need to take and just chill for a bit and stay away from a computer. After that, I'll be coming back to the same paid project but I'll only be working part-time, so I should have a decent amount of hours to put into OSS. I promise this will be one of the first issues I look into. Thanks so much for you patience hehe. |
Contributor
Author
|
LOL. No worries. I'm literally doing nothing on this issue, so it's easy to
be patient.
[image: --]
Mateu Aguiló Bosch
[image: https://]about.me/e0ipso
<https://about.me/e0ipso?promo=email_sig&utm_source=email_sig&utm_medium=email_sig&utm_campaign=external_links>
…On Wed, Aug 15, 2018 at 11:14 AM Luke Childs ***@***.***> wrote:
@e0ipso <https://github.com/e0ipso> ok so it's looking like I will
finally get around to this soon 😆
I've booked in two weeks holiday starting next week which I really need to
take and just chill for a bit and stay away from a computer.
After that, I'll be coming back to the same paid project but I'll only be
working part-time, so I should have a decent amount of hours to put into
OSS.
I promise this will be one of the first issues I look into.
Thanks so much for you patience hehe.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#61 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABFoqjag5dVhg9AqFsFLtJrezZqDODFjks5uQ-aHgaJpZM4Upwsi>
.
|
Contributor
jaredwray
added a commit
that referenced
this pull request
Dec 5, 2021
…f authors (#61) * adding nvmrc for node 16 * updating licensing with dates and authors * Delete yarn.lock * update for authors
jaredwray
added a commit
that referenced
this pull request
Dec 5, 2021
* Initial commit * Adapt Redis API * Run redis on Travis * Fix typo in description * Add npm keywords * Pass TTL functionality over to Redis * Create promisified redis methods on init * Create redis methods in loop * Make sure .get resolves to undefined if key doesn't exist * Update keyv * Use keyv-api-tests * 0.1.0 * Add usage example to readme * Add API docs to readme * Add support for .clear() * 0.2.0 * Don't expost Redis client * 1.0.0 * keyv => Keyv * 1.0.1 * Expose Redis client so events can be listened to * Show error handling in usage example * 1.1.0 * Add secondary description to readme * 1.1.1 * Make sure opts.uri from Keyv gets passed through to redis * Expose connect/error events directly on storage adapter * Only expose error event * Emit errors on keyv ee * Make sure opts is always defined * Update overview wording * Use JSONB to allow Buffers in JSON * Don't send undefined values to Redis Redis will save them as null. If we don't save them at all we'll retrun undefined on .get so everything works as expected. * No need for JSONB, it's used by default in Keyv now * 1.2.0 * Improve readability of get method * Migrate to keyv-test-suite * Run official keyv storage adapter tests * Add support for namespaces * Don't grab namespace from keyv * Use new store instace for each test * getter fn for namespace * Emit error events * 1.3.0 * Update dependencies to enable Greenkeeper 🌴 (#1) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * Remove Greenkeeper badge * Use "this" * Update to requirable * Pin dependency versions * 1.3.1 * Fix requirable version number * Update docs * Add Keyv logo to header * Tweak wording * 1.3.2 * Formatting * 1.3.3 * Update redis to the latest version 🚀 (#3) * 1.3.4 * Scope to @keyv * 1.3.5 * Use scoped dependencies * Fix package.json links * Import scoped test suite * 1.3.6 * Update ava to the latest version 🚀 (#6) * Support same constructor args as Keyv * Document creating storage adapter instance * 1.3.7 * Add .npmignore * 1.3.8 * Update coveralls to the latest version 🚀 (#8) * Update ava to the latest version 🚀 (#9) * Update ava to the latest version 🚀 (#10) * Update ava to the latest version 🚀 (#11) * chore(package): update xo to version 0.20.1 (#14) Closes #13 * Allow testing on non-localhost Redis, add docker config (#27) * Travis: Update Travis to current active LTS and higher (#28) * build: removed `ttlSupport` flag (#29) not longer necessary * Use ioredis client (#26) * 2.0.0 * build: Allow passing in an existing Redis instance (#30) * build: update dependencies (#31) * build: update dependencies * build: force * build: force * 2.1.0 * Update ioredis to ~4.16.0 (#34) * 2.1.1 * update ioredis (#38) * 2.1.2 * adding coverage for undefined going via set (#46) * upgrade nyc to 15.1.0 (#47) * adding yarn lock file (#48) adding yarn lock file * upgrading delay to version 5.0.0 (#49) upgrading delay to version 5.0.0 for maintenance * upgrading ioredis to version 4.27.9 (#50) maintenance update * upgrading ava to 3.15.0 (#51) maintenance update * Revert "upgrading ava to 3.15.0 (#51)" (#52) This reverts commit 2db6e7b2fa24c51abc215c0185e3df440c4ff290. * Update .travis.yml to support node 14 and 15 Update .travis.yml to support node 14 and 15 * upgrading ava to 3.15.0 (#53) upgrading ava to 3.15.0 for maintenance update * adding in support for node version 12 (#55) * upgrading xo to version 0.45.0 (#56) * upgrading xo to version 0.45.0 * moving to supporting 12,14,16 * upgrading ioredis to version 4.27.10 (#57) * keyv-redis package updated to 2.1.3 (#58) * initial check in of github actions (#59) * initial check in of github actions * updating to use redis * update readme with latest status badge * remove travis * Fix test suite import (#60) * Update to use latest npm with license and nvmrc plus license update of authors (#61) * adding nvmrc for node 16 * updating licensing with dates and authors * Delete yarn.lock * update for authors * Moving to docker compose for testing and build (#62) * moving to docker compose for testing and build * moving to docker compose for testing and build * rename yaml file * update to remove yarn.lock * adding in code coverage * updating logo and build badge * Update package.json (#63) * upgrading xo to version 0.46.4 (#64) * upgrading ioredis to version 4.28.0 (#65) * Add support for Redis clusters. (#37) * version bump to v2.2.0 * adding in ttlSupport (#66) * upgrading to @keyv/test-suite version 1.6.12 (#67) * rename to redis * no longer need build * Delete redis-compose.yaml * Delete .gitignore * no longer needed for mongo * no longer needed in mongo * updating for packaging Co-authored-by: Luke Childs <[email protected]> Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Casey Webb <[email protected]> Co-authored-by: Kiko Beats <[email protected]> Co-authored-by: Will Harney <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just created a project to add LRU as a store. I'd like to have official support for it. I noticed that the Keyv factory has stores hard-coded. Would you consider granting "official" status to https://github.com/e0ipso/keyv-lru?
This uses the
tiny-lrulibrary, which is faster thanquick-lru.I already integrated in the automated tests the official test suite.