Skip to content

support etcd#218

Merged
jaredwray merged 10 commits intojaredwray:masterfrom
jaytist:issue-55-etcd-support
Jan 31, 2022
Merged

support etcd#218
jaredwray merged 10 commits intojaredwray:masterfrom
jaytist:issue-55-etcd-support

Conversation

@jaytist
Copy link
Contributor

@jaytist jaytist commented Jan 27, 2022

Fixed #55

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #218 (c8b3b84) into master (7db919a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          11       11           
  Lines         458      467    +9     
=======================================
+ Hits          457      466    +9     
  Misses          1        1           
Impacted Files Coverage Δ
packages/keyv/src/index.js 100.00% <100.00%> (ø)
packages/test-suite/src/index.js 100.00% <0.00%> (ø)
packages/test-suite/src/values.js 100.00% <0.00%> (ø)
packages/test-suite/src/official.js 100.00% <0.00%> (ø)
packages/test-suite/src/namespace.js 100.00% <0.00%> (ø)
packages/test-suite/src/api.js 98.61% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db919a...c8b3b84. Read the comment docs.

@jaredwray
Copy link
Owner

@alphmth - is this ready for review? Did you get all the changes in? If so, let me know when this is ready.

@jaytist
Copy link
Contributor Author

jaytist commented Jan 29, 2022

@jaredwray namespace test is failing so working on that. hopefully by tomorrow you can review

@jaytist jaytist marked this pull request as ready for review January 31, 2022 08:07
@jaytist jaytist requested a review from jaredwray January 31, 2022 12:28
@jaredwray jaredwray merged commit e5dc6b6 into jaredwray:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage Adapter Etcd

2 participants