Skip to content

mongo - feat: migrating to hookified from eventemitter#1869

Merged
jaredwray merged 1 commit intomainfrom
mongo---feat-migrating-to-hookified-from-eventemitter
Feb 25, 2026
Merged

mongo - feat: migrating to hookified from eventemitter#1869
jaredwray merged 1 commit intomainfrom
mongo---feat-migrating-to-hookified-from-eventemitter

Conversation

@jaredwray
Copy link
Owner

@jaredwray jaredwray commented Feb 25, 2026 •
edited
Loading

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
mongo - feat: migrating to hookified from eventemitter

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 25, 2026

Summary of Changes

Hello @jaredwray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the MongoDB storage adapter by replacing the traditional Node.js EventEmitter with the Hookified library. This change aims to improve the internal event handling and extensibility of the KeyvMongo class, aligning it with contemporary patterns for managing lifecycle hooks and asynchronous operations. The update also includes necessary dependency adjustments and lockfile synchronization.

Highlights

  • Migration to Hookified: The KeyvMongo class in the MongoDB storage adapter has been refactored to extend Hookified instead of EventEmitter, leveraging a more modern and potentially more efficient event/hooking mechanism.
  • Dependency Update: The hookified package has been added as a new dependency for the MongoDB storage adapter.
  • Lockfile Updates: The pnpm-lock.yaml file has been updated to reflect the new hookified dependency and to bump @types/node to version 25.0.2 across several development dependencies.
Changelog
  • pnpm-lock.yaml
    • Added 'hookified' as a dependency for the 'storage/mongo' package.
    • Updated '@types/node' dependency version from '24.10.4' to '25.0.2' in various development packages.
    • Removed the 'optional: true' flag for '@types/[email protected]' snapshot.
    • Removed a specific '@vitest/mocker' entry, likely due to dependency resolution changes.
  • storage/mongo/package.json
    • Added 'hookified' with version '^1.13.0' to the dependencies.
  • storage/mongo/src/index.ts
    • Replaced the import of 'EventEmitter' from 'node:events' with 'Hookified' from 'hookified'.
    • Modified the 'KeyvMongo' class to extend 'Hookified' instead of 'EventEmitter'.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 25, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the @keyv/mongo storage adapter from Node.js's built-in EventEmitter to hookified. This is achieved by adding hookified as a dependency in package.json and pnpm-lock.yaml, and updating the KeyvMongo class in src/index.ts to extend Hookified instead of EventEmitter. The changes are minimal, targeted, and appear to correctly implement the intended migration.

@codecov
Copy link

codecov bot commented Feb 25, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96%. Comparing base (1655532) to head (70492b5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1869   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          32       32           
  Lines        2694     2694           
  Branches      472      472           
=======================================
  Hits         2693     2693           
  Misses          1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit c1fd176 into main Feb 25, 2026
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jaredwray