Skip to content

mysql - feat: moving from eventemitter to hookified#1867

Merged
jaredwray merged 1 commit intomainfrom
mysql---feat-moving-from-eventemitter-to-hookified
Feb 25, 2026
Merged

mysql - feat: moving from eventemitter to hookified#1867
jaredwray merged 1 commit intomainfrom
mysql---feat-moving-from-eventemitter-to-hookified

Conversation

@jaredwray
Copy link
Owner

@jaredwray jaredwray commented Feb 25, 2026 •
edited
Loading

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
mysql - feat: moving from eventemitter to hookified

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 25, 2026

Summary of Changes

Hello @jaredwray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly updates the KeyvMysql storage adapter by migrating its internal event management from the traditional EventEmitter to the hookified library. This change aims to enhance the flexibility and structure of event handling within the MySQL adapter, providing a more modern approach to managing lifecycle events and custom logic execution points.

Highlights

  • Core Logic Refactor: The KeyvMysql class has been refactored to extend Hookified instead of Node.js's native EventEmitter, modernizing its event handling mechanism.
  • Dependency Update: The hookified library has been added as a new dependency for the MySQL storage adapter.
  • Lockfile Adjustments: The pnpm-lock.yaml file was updated to reflect the new hookified dependency and included adjustments to @types/node versions for several development packages.
Changelog
  • pnpm-lock.yaml
    • Added hookified as a dependency for the storage/mysql package.
    • Updated @types/node versions for several development dependencies like @vitest/coverage-v8, ts-node, and vitest within the lockfile.
    • Added a deprecation warning for [email protected].
    • Marked @types/[email protected] as optional.
    • Adjusted @vitest/mocker dependency resolution.
  • storage/mysql/package.json
    • Added hookified with version ^1.13.0 to the dependencies.
  • storage/mysql/src/index.ts
    • Replaced the import of EventEmitter from node:events with Hookified from the hookified package.
    • Updated the KeyvMysql class to extend Hookified instead of EventEmitter.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 25, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the @keyv/mysql package from using EventEmitter to hookified, which aligns with the apparent goal of standardizing event handling across the project. The code changes are straightforward and correct. However, a review of the pnpm-lock.yaml file has surfaced a critical security issue related to a deprecated version of the glob package, which must be addressed.

@codecov
Copy link

codecov bot commented Feb 25, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.92%. Comparing base (1ad599d) to head (d2d20e9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1867   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          32       32           
  Lines        2694     2694           
  Branches      471      471           
=======================================
  Hits         2692     2692           
  Misses          2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit 8012bdb into main Feb 25, 2026
10 checks passed
@jaredwray jaredwray deleted the mysql---feat-moving-from-eventemitter-to-hookified branch February 25, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jaredwray