Skip to content

memcache - fix: removing serialization as not needed#1848

Merged
jaredwray merged 1 commit intomainfrom
memcache---fix-removing-serialization-as-not-needed
Feb 17, 2026
Merged

memcache - fix: removing serialization as not needed#1848
jaredwray merged 1 commit intomainfrom
memcache---fix-removing-serialization-as-not-needed

Conversation

@jaredwray
Copy link
Owner

@jaredwray jaredwray commented Feb 17, 2026 •
edited
Loading

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
memcache - fix: removing serialization as not needed

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 17, 2026

Summary of Changes

Hello @jaredwray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the memcache storage adapter by eliminating an unnecessary serialization dependency and its associated logic. The change simplifies the internal workings of the get method, making it more direct in handling retrieved values and non-existent keys, which improves efficiency and reduces the overall footprint of the module.

Highlights

  • Dependency Removal: The @keyv/serialize dependency has been completely removed from the memcache storage adapter, including its entry in pnpm-lock.yaml and package.json.
  • Serialization Logic Simplification: The defaultDeserialize import and the conditional deserialization logic within the get method of KeyvMemcache have been removed, simplifying how values are retrieved.
  • Undefined Value Handling: The get method now directly returns undefined when a value is not found, instead of an object { value: undefined, expires: 0 }.
  • Test Updates: The keyvMemcache getMany test has been updated to reflect the new behavior of returning undefined for non-existent keys.
Changelog
  • pnpm-lock.yaml
    • Removed @keyv/serialize dependency from the storage/memcache section.
  • storage/memcache/package.json
    • Removed @keyv/serialize from the dependencies list.
  • storage/memcache/src/index.ts
    • Removed the import of defaultDeserialize from @keyv/serialize.
    • Modified the get method to return undefined directly when a value is not found.
    • Removed the deserialize option check and defaultDeserialize call, now casting the retrieved value directly.
  • storage/memcache/test/test.ts
    • Updated the keyvMemcache getMany test expectation to assert toBeUndefined() instead of toEqual({ expires: 0, value: undefined }) for non-existent keys.
Activity
  • The pull request was created by jaredwray.
  • The author has marked the PR as fulfilling the contributing and code of conduct guidelines.
  • The author has indicated that tests for the changes have not yet been added with 100% code coverage.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 17, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the serialization logic from the memcache adapter, which is the right approach as Keyv itself handles serialization. This fixes a potential double-deserialization issue. The changes are logical and the updated test reflects the new behavior correctly. I've pointed out a minor type-safety issue in the type casting within the get method.

@jaredwray jaredwray merged commit 4ea0e3e into main Feb 17, 2026
8 checks passed
@jaredwray jaredwray deleted the memcache---fix-removing-serialization-as-not-needed branch February 17, 2026 03:56
@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (5bcbf60) to head (964bef8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1848      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files          32       32              
  Lines        2438     2437       -1     
  Branches      441      440       -1     
==========================================
- Hits         2437     2436       -1     
  Misses          1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jaredwray