Skip to content

memcache - feat: adding in createKeyv helper function#1847

Merged
jaredwray merged 1 commit intomainfrom
memcache---feat-adding-in-createKeyv-helper-function
Feb 17, 2026
Merged

memcache - feat: adding in createKeyv helper function#1847
jaredwray merged 1 commit intomainfrom
memcache---feat-adding-in-createKeyv-helper-function

Conversation

@jaredwray
Copy link
Owner

@jaredwray jaredwray commented Feb 17, 2026 •
edited
Loading

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
memcache - feat: adding in createKeyv helper function

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 17, 2026

Summary of Changes

Hello @jaredwray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the @keyv/memcache package by adding a createKeyv helper function. This function provides a more streamlined and convenient way for users to initialize a Keyv instance pre-configured with a Memcache store, thereby improving the developer experience by reducing setup boilerplate.

Highlights

  • New Helper Function: A createKeyv helper function has been introduced to simplify the instantiation of a Keyv client with a Memcache store.
  • Documentation Update: The README.md file has been updated with a new 'Quick Start with createKeyv' section, including usage examples.
  • Test Coverage: A new test case was added to ensure the createKeyv helper function correctly returns a Keyv instance.
Changelog
  • storage/memcache/README.md
    • Added a 'Quick Start with createKeyv' section.
    • Updated the table of contents to include the new quick start guide.
  • storage/memcache/src/index.ts
    • Exported the new createKeyv helper function.
    • Imported the Keyv class from the 'keyv' package.
  • storage/memcache/test/test.ts
    • Imported the createKeyv function for testing.
    • Added a test to verify that createKeyv returns a Keyv instance.
Activity
  • No human activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 17, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a createKeyv helper function for the memcache storage adapter. The implementation is straightforward, but I've suggested an improvement to make it more flexible by allowing Keyv options to be passed during creation. This would significantly increase the utility of the helper for more complex scenarios. The documentation and tests have been updated accordingly for the new function.

@codecov
Copy link

codecov bot commented Feb 17, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (3651aa7) to head (5781519).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1847   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files          32       32           
  Lines        2436     2438    +2     
  Branches      441      441           
=======================================
+ Hits         2435     2437    +2     
  Misses          1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit 5bcbf60 into main Feb 17, 2026
10 checks passed
@jaredwray jaredwray deleted the memcache---feat-adding-in-createKeyv-helper-function branch February 17, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jaredwray