mono - refactor: remove ttlSupport property from all storage adapters by jaredwray · Pull Request #1842 · jaredwray/keyv

jaredwray · 2026-02-15T22:32:50Z

The ttlSupport property is no longer needed as Keyv now automatically
handles TTL support detection. Removed from sqlite, mongo, postgres,
dynamo, valkey, etcd, mysql, and memcache adapters. Updated etcd to
use direct opts.ttl check instead of the removed property, and updated
related tests to verify behavior without ttlSupport.

https://claude.ai/code/session_01XambjE8LDvEZ7zSXKnhpuR

The ttlSupport property is no longer needed as Keyv now automatically handles TTL support detection. Removed from sqlite, mongo, postgres, dynamo, valkey, etcd, mysql, and memcache adapters. Updated etcd to use direct opts.ttl check instead of the removed property, and updated related tests to verify behavior without ttlSupport. https://claude.ai/code/session_01XambjE8LDvEZ7zSXKnhpuR

gemini-code-assist · 2026-02-15T22:33:09Z

Summary of Changes

Hello @jaredwray, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the Keyv storage adapter codebase by eliminating the ttlSupport property, which is no longer necessary due to Keyv's automated TTL detection. The change simplifies the implementation across various adapters and updates the Etcd adapter's logic and its corresponding tests to align with this new, more efficient approach to handling Time-To-Live functionality.

Highlights

Removed ttlSupport property: The ttlSupport property has been removed from all Keyv storage adapters, including Dynamo, Etcd, Memcache, Mongo, MySQL, Postgres, SQLite, and Valkey, as Keyv now handles TTL support detection automatically.
Etcd adapter update: The Etcd adapter was updated to directly check opts.ttl for TTL support, replacing the reliance on the removed ttlSupport property.
Test updates: Related tests for Etcd and MySQL adapters were modified to reflect the removal of ttlSupport and now verify TTL behavior using alternative checks, such as store.lease.

Changelog

storage/dynamo/src/index.ts
- Removed the ttlSupport property from the KeyvDynamo class.
storage/etcd/src/index.ts
- Removed the ttlSupport property declaration from the KeyvEtcd class.
- Eliminated the initialization of this.ttlSupport in the constructor.
- Updated the conditional check for TTL support from this.ttlSupport to typeof this.opts.ttl === "number".
storage/etcd/test/test.ts
- Updated test assertions to check for store.lease definition instead of store.ttlSupport to verify TTL enablement or disablement.
storage/memcache/src/index.ts
- Removed the ttlSupport property from the KeyvMemcache class.
storage/mongo/src/index.ts
- Removed the ttlSupport property from the KeyvMongo class.
storage/mysql/src/index.ts
- Removed the ttlSupport property declaration and its associated JSDoc comments.
- Eliminated the conditional assignment of this.ttlSupport in the constructor.
storage/mysql/test/test.ts
- Removed assertions related to keyv.ttlSupport in tests for intervalExpiration.
storage/postgres/src/index.ts
- Removed the ttlSupport property declaration and its initialization in the constructor of the KeyvPostgres class.
storage/sqlite/src/index.ts
- Removed the ttlSupport property declaration and its initialization in the constructor of the KeyvSqlite class.
storage/valkey/src/index.ts
- Removed the ttlSupport property from the KeyvValkey class.

Activity

No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly removes the ttlSupport property from all specified storage adapters, aligning with the core Keyv change that makes this property obsolete. The refactoring is consistent across all adapters. The logic in the etcd adapter and its tests have been appropriately updated to reflect the removal of ttlSupport. I have one suggestion regarding a test case in the MySQL adapter that has been weakened as a result of this change.

storage/mysql/test/test.ts

codecov · 2026-02-15T22:37:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (99cfbd4) to head (f2672ef).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #1842   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines         2446      2432   -14     
  Branches       451       447    -4     
=========================================
- Hits          2446      2432   -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The test only checked that the object was defined after removing ttlSupport, providing no meaningful coverage for the intervalExpiration behavior. https://claude.ai/code/session_01XambjE8LDvEZ7zSXKnhpuR

gemini-code-assist bot reviewed Feb 15, 2026

View reviewed changes

storage/mysql/test/test.ts Outdated Show resolved Hide resolved

jaredwray merged commit a898742 into main Feb 15, 2026
10 checks passed

jaredwray deleted the claude/remove-ttl-support-kIjnk branch February 16, 2026 23:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mono - refactor: remove ttlSupport property from all storage adapters#1842

mono - refactor: remove ttlSupport property from all storage adapters#1842
jaredwray merged 2 commits intomainfrom
claude/remove-ttl-support-kIjnk

jaredwray commented Feb 15, 2026

Uh oh!

gemini-code-assist bot commented Feb 15, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

codecov bot commented Feb 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jaredwray commented Feb 15, 2026

Uh oh!

gemini-code-assist bot commented Feb 15, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

codecov bot commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Feb 15, 2026 •

edited

Loading