mysql - fix: documentation and error checking fixes#1819
Merged
Conversation
…g them The .catch() handler was swallowing connection errors by calling emit() and returning its boolean result. This caused the `connected` promise to resolve to a boolean instead of rejecting, leading to silent failures when calling set() or other methods. Now the error is re-thrown after emitting, ensuring proper error propagation. Fixes #1807
- Removed .catch() handler that was swallowing connection errors by resolving the promise to a boolean instead of rejecting - Fixed README documentation that incorrectly showed MySQL-specific options (table, keySize, intervalExpiration) being passed to Keyv instead of KeyvMysql Fixes #1807
Owner
Author
|
@codex review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1819 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 2425 2425
Branches 442 442
=========================================
Hits 2425 2425 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c143a106ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
mysql - fix: documentation and error checking fixes