Skip to content

postgres - fix: moving to faker for unique tests#1814

Merged
jaredwray merged 2 commits intomainfrom
postgres---fix-moving-to-faker-for-unique-tests
Jan 20, 2026
Merged

postgres - fix: moving to faker for unique tests#1814
jaredwray merged 2 commits intomainfrom
postgres---fix-moving-to-faker-for-unique-tests

Conversation

@jaredwray
Copy link
Owner

@jaredwray jaredwray commented Jan 20, 2026 •
edited
Loading

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
postgres - fix: moving to faker for unique tests

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 20, 2026

Summary of Changes

Hello @jaredwray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the testing suite for the postgres package by integrating the @faker-js/faker library. The core change involves replacing static, hardcoded test data with dynamically generated unique keys and values. This significantly improves the robustness and reliability of tests, particularly in scenarios involving concurrent or repeated test runs, by preventing potential data collisions and ensuring that tests operate on distinct, fresh data.

Highlights

  • Dependency Update: Added @faker-js/faker as a development dependency to the packages/postgres/package.json file.
  • Enhanced Test Uniqueness: Modified various test files (test-ssl.ts, test.ts) to replace hardcoded keys and values with dynamically generated unique strings and sentences using faker.string.alphanumeric() and faker.lorem.sentence().
  • Improved Iterator Test Logic: Updated iterator tests to collect all generated keys and values and assert their presence using toContain, making the tests more resilient to potential order variations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 20, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great improvement, replacing hardcoded test data with dynamic data from faker.js. This makes the tests more robust and less prone to collisions. I've added a few suggestions to further improve the test assertions, particularly for iterator tests, to ensure they correctly verify key-value pairs. I also noted a small redundancy in one of the tests.

@jaredwray
Copy link
Owner Author

jaredwray commented Jan 20, 2026

@codex review

@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Jan 20, 2026

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov
Copy link

codecov bot commented Jan 20, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (675f5fc) to head (472c6d8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #1814   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines         2402      2414   +12     
  Branches       436       436           
=========================================
+ Hits          2402      2414   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit e5a71f1 into main Jan 20, 2026
10 checks passed
@jaredwray jaredwray deleted the postgres---fix-moving-to-faker-for-unique-tests branch January 20, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jaredwray