Conversation
…nection on module load (#1805) The class field initializer `_client = createClient()` was executing at module load time, causing Redis connection attempts before any KeyvRedis instance was created. This caused issues with: - Startup hangs when localhost:6379 is unavailable - OpenTelemetry instrumentation missing initialization - Serverless cold start delays - Testing complications with mock Redis Moved client initialization from class field to constructor so connections only occur when explicitly instantiating KeyvRedis or calling createKeyv().
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1806 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 2401 2402 +1
Branches 435 436 +1
=========================================
+ Hits 2401 2402 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class field initializer
_client = createClient()was executing at module load time,causing Redis connection attempts before any KeyvRedis instance was created. This caused
issues with:
Moved client initialization from class field to constructor so connections only occur
when explicitly instantiating KeyvRedis or calling createKeyv().