[WIP] Update stack PR for postgres iteration resiliency improvements#1788
Closed
Copilot wants to merge 1 commit intopostgres---fix-iteration-with-more-resiliencyfrom
Closed
[WIP] Update stack PR for postgres iteration resiliency improvements#1788Copilot wants to merge 1 commit intopostgres---fix-iteration-with-more-resiliencyfrom
Copilot wants to merge 1 commit intopostgres---fix-iteration-with-more-resiliencyfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: Apply
escapeIdentifierconsistently across all methodsBased on the feedback, I need to apply the
escapeIdentifierfunction to all SQL queries that use schema and table names, not just theiterator()method.escapeIdentifiertoget()method (line 80)escapeIdentifiertogetMany()method (line 87)escapeIdentifiertoset()method (line 96)escapeIdentifiertosetMany()method (line 110)escapeIdentifiertodelete()method (lines 118-119)escapeIdentifiertodeleteMany()method (lines 131-132)escapeIdentifiertoclear()method (line 144)escapeIdentifiertohas()method (line 199)escapeIdentifierto constructor'screateTable(lines 48, 51)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.