Skip to content

postgres - chore: connect method as public#1681

Merged
jaredwray merged 2 commits intojaredwray:mainfrom
darky:pg-connect-protected
Nov 8, 2025
Merged

postgres - chore: connect method as public#1681
jaredwray merged 2 commits intojaredwray:mainfrom
darky:pg-connect-protected

Conversation

@darky
Copy link
Contributor

@darky darky commented Nov 8, 2025

While we are waiting #1680 (if it will of course) here's small cosmetic change for ability to implement own PGlite support like

class KeyvPglite extends KeyvPostgres {
  override connect() {
    // PGlite connect
  }
  
  override disconnect() {
    // PGlite disconnect
  }
}

The rest should works out of the box

@jaredwray
Copy link
Owner

@darky - can we make the functions public instead of protected for flexibility?

@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (77722e6) to head (580f184).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1681   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines         3114      3114           
  Branches       785       786    +1     
=========================================
  Hits          3114      3114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@darky darky changed the title postgres - connect method as protected postgres - chore: connect method as public Nov 8, 2025
@jaredwray jaredwray merged commit 3f1b41b into jaredwray:main Nov 8, 2025
8 checks passed
@jaredwray
Copy link
Owner

@darky - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants