(fix): jest config parsing shouldn't silently fail on error (#499)

agilgur5 · web-flow · commit a97a5af1cc67 · 2020-02-07T14:50:13.000-05:00
- before if your jest.config.js had an error in it, the try/catch would
  just ignore it and pretend like your jest.config.js didn't exist
  - this caused me a lot of confusion as to why my customizations
    seemingly weren't being read at all

- instead of try/catching a MODULE_NOT_FOUND, check if it exists first,
  and only then do parsing
  - and let it throw an error if there is one, don't cover it up
diff --git a/src/index.ts b/src/index.ts
@@ -534,11 +534,13 @@ prog
       ),
       ...appPackageJson.jest,
     };
-    try {
-      // Allow overriding with jest.config
+
+    // Allow overriding with jest.config
+    const jestConfigExists = await fs.pathExists(paths.jestConfig);
+    if (jestConfigExists) {
       const jestConfigContents = require(paths.jestConfig);
       jestConfig = { ...jestConfig, ...jestConfigContents };
-    } catch {}
+    }
 
     argv.push(
       '--config',
