(feat): support JS & JSX files in tsdx lint (#487)

agilgur5 · web-flow · commit 655bb531b5e8 · 2020-02-03T23:18:38.000-05:00
- JS &amp; JSX are already supported in tsdx build, so this is just adding
  some better parity in tsdx test
  - more JS &amp; JSX support also means better support for gradual TS
    migrations

- prior to this, JS &amp; JSX files wouldn't be linted unless explicitly
  included with a glob or something
  - extensions is also only configurable via CLIEngine, .eslintrc
    doesn't currently support it

- fix errors &amp; warnings in JS test files as TSDX dogfoods its own lint
  functionality
diff --git a/src/index.ts b/src/index.ts
@@ -593,7 +593,7 @@ prog
           ...config,
           ...appPackageJson.eslint,
         },
-        extensions: ['.ts', '.tsx'],
+        extensions: ['.ts', '.tsx', '.js', '.jsx'],
         fix: opts.fix,
         ignorePattern: opts['ignore-pattern'],
       });
diff --git a/test/fixtures/build-withConfig/errors/ErrorDev.js b/test/fixtures/build-withConfig/errors/ErrorDev.js
@@ -1,9 +1,7 @@
-
 function ErrorDev(message) {
   const error = new Error(message);
   error.name = 'Invariant Violation';
   return error;
 }
 
-export default ErrorDev;      
-      
+export default ErrorDev;
diff --git a/test/fixtures/build-withConfig/errors/ErrorProd.js b/test/fixtures/build-withConfig/errors/ErrorProd.js
@@ -1,4 +1,3 @@
-
 function ErrorProd(code) {
   // TODO: replace this URL with yours
   let url = 'https://reactjs.org/docs/error-decoder.html?invariant=' + code;
diff --git a/test/fixtures/util.js b/test/fixtures/util.js
@@ -1,5 +1,3 @@
-'use strict';
-
 const shell = require('shelljs');
 const path = require('path');
 const rootDir = process.cwd();
diff --git a/test/utils/psKill.js b/test/utils/psKill.js
@@ -1,5 +1,3 @@
-'use strict';
-
 const psTree = require('ps-tree');
 
 // Loops through processes and kills them

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-`
`2`	`1`	`function ErrorProd(code) {`
`3`	`2`	`// TODO: replace this URL with yours`
`4`	`3`	`let url = 'https://reactjs.org/docs/error-decoder.html?invariant=' + code;`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-'use strict';`
`2`		`-`
`3`	`1`	`const shell = require('shelljs');`
`4`	`2`	`const path = require('path');`
`5`	`3`	`const rootDir = process.cwd();`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-'use strict';`
`2`		`-`
`3`	`1`	`const psTree = require('ps-tree');`
`4`	`2`
`5`	`3`	`// Loops through processes and kills them`