add a couple of type annotations#689
Merged
jaraco merged 4 commits intojaraco:mainfrom Aug 22, 2024
dimbleby:type-annotations
Merged
add a couple of type annotations#689jaraco merged 4 commits intojaraco:mainfrom dimbleby:type-annotations
jaraco merged 4 commits intojaraco:mainfrom
dimbleby:type-annotations
Conversation
jaraco
reviewed
Aug 22, 2024
stefanor
added a commit
to stefanor/twine
that referenced
this pull request
Sep 25, 2024
Improved typing in keyring: jaraco/keyring#689
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into
untyped-callwarnings using theSimpleCredential- so here is a pull request adding annotations incredentials.py.(There is a lot of unannotated code in this repository, I have no plans to do anything about the rest of it)