Fix: inconsistent use of caml_stat_* functions#68
Closed
murmour wants to merge 1 commit intojanestreet:masterfrom
Closed
Fix: inconsistent use of caml_stat_* functions#68murmour wants to merge 1 commit intojanestreet:masterfrom
murmour wants to merge 1 commit intojanestreet:masterfrom
Conversation
Author
Thank you for raising this important point. I'm pretty sure that By the way, right now I'm investigating some probable leaks inside your excellent |
|
This is available on master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. I'm doing a large-scale study of C stub sources on OPAM.
Your library makes use of the undocumented
caml_stat_*functions, which currently are thin wrappers aroundmalloc,realloc, andfreefrom the C standard library. In future, the implementation of these functions may change, making them incompatible withmallocand breaking the code that abused the old undocumented semantics.Regardless of whether the change of semantics will happen or not, being consistent about such matters should be considered good style.