Skip to content

Comments

[en] Update en-Linux-Install-Script.md#97

Closed
trebmuh wants to merge 3 commits intojamulussoftware:changesfrom
trebmuh:patch-1
Closed

[en] Update en-Linux-Install-Script.md#97
trebmuh wants to merge 3 commits intojamulussoftware:changesfrom
trebmuh:patch-1

Conversation

@trebmuh
Copy link
Member

@trebmuh trebmuh commented Nov 28, 2020

A few improvements and typos spotted while doing the French translation of this page.

I've got a doubt about this sentence:

[...] all the commands above into one script [...]

There are no command "above" so they're is something wrong. It might well be talking about either the commands in another page or the commands below.

@gilgongo can you please have a look to it and advise? I'll add it to this PR then.

@gilgongo
Copy link
Member

Ah, this was one of the contributions I was a bit worried about as I'd not been able to check it.

The whole thing was originally simply pasted into the middle the Linux install page by somebody on the wiki. Rather than offend them by removing it, I put it into a separate document and linked it from the Linux install page. So that might explain the "above" thing. I'd sort of assumed that anyone in their right mind would not read it (it looks far too much trouble to actually do).

It looks likely that we can move it to the new "community" area for SEO food, and where I think it can be picked over by anyone who wants to. So, how about you just translate it as is, I'll remove the link to it from the English Linux install page, and we can deal with it later along with the other things for the community section?

Copy link
Contributor

@gegeweb gegeweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@trebmuh
Copy link
Member Author

trebmuh commented Nov 28, 2020

So, how about you just translate it as is, I'll remove the link to it from the English Linux install page, and we can deal with it later along with the other things for the community section?

I assume that you talk about the "above" here. If so, I'm OK with that.
@gilgongo you can merge this PR then (the "above" is untouched) if you're fine with the other changes too.

@ann0see
Copy link
Member

ann0see commented Nov 28, 2020

@trebmuh
Copy link
Member Author

trebmuh commented Nov 28, 2020

@ann0see : is that the person who wrote this first?

@gilgongo
Copy link
Member

@trebmuh Yes. And we can't call him the Sonic Emperor, unfortunately.

@trebmuh
Copy link
Member Author

trebmuh commented Nov 28, 2020

@gilgongo I don't get what the meaning intended in your last sentence.
I've checked his github page and it seems to be active on github.
We could/should simply tag him here, isn't?

@trebmuh
Copy link
Member Author

trebmuh commented Nov 28, 2020

(conflicts resolved in the file)

@gilgongo
Copy link
Member

Yes, we can tag him here.

@trebmuh
Copy link
Member Author

trebmuh commented Nov 28, 2020

Hi @niebert. We don't know each other yet, but it looks like you've been writing the original documentation that we're working on in this thread. Could you please help us here and suggest how we should reformulate this sentence we're talking about?

@ann0see ann0see changed the title Update en-Linux-Install-Script.md [en] Update en-Linux-Install-Script.md Nov 30, 2020
@ann0see

This comment has been minimized.

@trebmuh

This comment has been minimized.

@ann0see

This comment has been minimized.

@ann0see
Copy link
Member

ann0see commented Dec 8, 2020

jamulussoftware/jamulus#705 (comment)

Furthermore I want to ask you to remove the annotation "sonic emperor" from my name on the Web Site https://github.com/jamulussoftware/jamulussoftware.github.io/blob/main/wiki/en/en-Tips-Tricks-More.md - you can remove or improve my edits or use them or build on them if you think there are useful according to you quality assurance quidlines. My comments were good faith edits.

So I think @trebmuh you can improve and fix his edits.

@trebmuh
Copy link
Member Author

trebmuh commented Dec 9, 2020

@ann0see I'm fine to do so. You're OK with merging this as a blog post as suggested be gilgongo above IIUC?

@ann0see
Copy link
Member

ann0see commented Dec 10, 2020

Yes. It should be in the new community section.

@niebert
Copy link

niebert commented Dec 10, 2020

Excuse me for the late reply, the contribution was made to Volker Fischers repository. Please feel free to edit the script. Created that just as support for people that battle to put all the required command lines in the Linux shell. At the same time I thought it might also be helpful for other OpenSource community members that want to use Jamulus on Linux. I wrote that script for Volker Fischers repository have multi distro support in mind (Ubuntu, Mint, ...) and handle that in one script with a distro dependent call of install commands e.g. apt-get on Ubuntu. Furthermore specific distro and version specific dependent install command might be required, e.g. a version specific install command like sudo apt-get lib-on-18.4 for Ubuntu 18.4 and sudo apt-get lib-on-20.4 for Ubuntu 20.4 . With a shell script and sed or with NodeJS the distro and version specific install scripts can be generated within a build processed. That sets just the build variables for the distribution and version in the shell variable at the top of the script and users can just run the jamulus-ubuntu-18-4-client-install.sh or jamulus-ubuntu-20-4-client-install.sh without asking them about their Linux DIstro and the Linux Version. Anyway thank you all for supporting this great piece of software. Might create a small repository for my scripts and you can decide if they make sense to you to integrate them to the Jamulus repository for clients or servers.
Best regards,

@ann0see
Copy link
Member

ann0see commented Dec 10, 2020

Great! Thanks for your reply!

@niebert do you want to do the changes or should @trebmuh do them?

In my opinion @niebert, we should also discuss the Software Synth Page. (We should add pictures, a few clarifications etc.) should we open a PR on that? Edit: done: #170

@ann0see
Copy link
Member

ann0see commented Dec 10, 2020

Edit: now a real reply to your answer (I now have a bit more time...) @niebert

Might create a small repository for my scripts and you can decide if they make sense to you to integrate them to the Jamulus repository for clients or servers.

Yes, I think that's the best solution.

We can link the scripts from the page with your descriptions? This allows you to make changes more easily. We can then restructure this page a bit and link to your repo.

I wrote that script for Volker Fischers repository have multi distro support in mind (Ubuntu, Mint, ...) and handle that in one script with a distro dependent call of install commands e.g. apt-get on Ubuntu

Yes. That's a good idea (although the installation is not too difficult in my opinion). Also we have a few packages already available (but at least for Debian it will take some time)

With a shell script and sed or with NodeJS the distro and version specific install scripts can be generated within a build processed.

Do you mean "build process"? Yes, I think it would be great if @corrados also compiled linux binaries. He can use these scripts (but will also need multiple distros on his device). I think we could also try building with a github action or travis cli. Please open an issue on the main repo for that.

@ann0see
Copy link
Member

ann0see commented Dec 10, 2020

Closed in favour of #171

@ann0see ann0see closed this Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants