Use configured Directory Public IP for Client when hole-punching#815
Merged
pljones merged 1 commit intojamulussoftware:next-releasefrom Sep 7, 2022
Conversation
5 tasks
pljones
force-pushed
the
bugfix/#812-use-public-ip-for-holepunch
branch
2 times, most recently
from
6b959c3 to
5504eba
Compare
pljones
force-pushed
the
bugfix/#812-use-public-ip-for-holepunch
branch
from
5504eba to
c3ed3b8
Compare
hoffie
approved these changes
Sep 7, 2022
Member
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
LGTM.
This describes some real edge case and may be hard to understand for the average user, but I don't think it can be described in any simpler ways as the scenario is... special. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Adds the hint for "hole punch" for anyone running a directory and clients on the same LAN, along with public servers.
Context: Fixes an issue? Related issues
Fixes: #812
Status of this Pull Request
Also adjusted a couple of the other hints and tried to use the appropriate wording here (i.e. not exactly what I'd said in 812).
What is missing until this pull request can be merged?
Review:
Old: https://jamulus.io/wiki/Custom-Directories
New: http://jamuluswebsite.drealm.info/wiki/Directories
Does this need translation?
Yes.
Checklist